Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !2329

fix: unlock job when moving it to delayed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/papandreou/fix/releaseLockAfterRemovingToDelayed into develop Mar 21, 2022
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: papandreou

Hi! For various reasons I'm using a rather high lockDuration setting in my app, and I noticed that jobs that fail an attempt and have to be moved to delayed remain locked. This means that I cannot easily remove such a job from our small homegrown queue control app, as it isn't the lock-taker.

When I tried to figure out what was going on, I noticed this comment: https://github.com/OptimalBits/bull/blob/61a87a8509bfc9227775084839544c444d69994d/lib/job.js#L309

... However, it seems like the job isn't actually being unlocked by moveToDelayed-3, so I tried fixing that 😇

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/papandreou/fix/releaseLockAfterRemovingToDelayed