Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !452

Fix for max 24 day delay issue #244

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mwielbut/max-timeout-delay-issue into master Feb 17, 2017
  • Overview 11
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: mwielbut

The implementation of setTimeout in Nodejs relies on a 32 bit integer for timeout values. The current default timeout in the delay timer is the max 64 bit integer which causes any possible delay values to start the delay timer. Delays longer than 2^31-1 ms (roughly 24 days) cause an integer overflow and the timeout triggers immediately.

This pull request replaces the default timeout with the max 32bit signed integer so that only valid ms values can start the timer. Anything longer than 24 days will be caught by the guardian timer.

To reproduce this issue clear anything in the delay set and create a new job with a delay > 2^31 ms. It will execute immediately.

https://nodejs.org/docs/latest/api/timers.html#timers_settimeout_callback_delay_args

#244 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mwielbut/max-timeout-delay-issue