Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !520

Script events. fixes #501

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Manuel Astudillo requested to merge script-events into v3.0.0 Apr 27, 2017
  • Overview 3
  • Commits 15
  • Pipelines 0
  • Changes 15

In this PR we get rid of the "disturbed" dependency, and instead we publish global events from the lua scripts. This is faster and more reliable. For local events, we try to emit them directly. Local events and global are not identical, I will need to improve the documentation on this ASAP. For example while the local progress event sends the job as first parameter (since this can be get for free), in the global event we only send the jobId, to avoid fetching the job data everytime the progress is updated.

I also did some minor refactoring and removed the obsolete priority queue code and unit tests.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: script-events