Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !57

Tests fix - initial work

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/codazzo/tests-fix into master Aug 29, 2014
  • Overview 11
  • Commits 7
  • Pipelines 0
  • Changes 7

Created by: codazzo

Hi @manast - I would like to add a timeout and a retries parameter to Queue##add(data, opts). I have noticed the build is failing on master - this could be due to the upgrade to Bluebird 2.x I have taken a look at the source and noticed some places where the use promises could be simplified so I thought I would issue this PR. My idea would be to do something similar for job.js and add a few more tests before moving on to implementing the features I mentioned. What are your thoughts?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/codazzo/tests-fix