Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !589

Lazily initialize redis clients, reduce side effects of `Queue` instantiation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/marshall007/marshall_526 into master Jun 26, 2017
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: marshall007

Supersedes #586

Sorry I had to create a new PR, pushing additional commits onto my branch wasn't updating the existing PR. I think I ran into https://github.com/isaacs/github/issues/591.


Fixes #526 (closed)

This PR ensures that the client and eclient redis connections are not instantiated until they are absolutely needed. This in turn reduces the number of bound event listeners by default.

Additionally, I have added a skipVersionCheck option which, when true, avoids creating a redis connection and sanity checking the MINIMUM_REDIS_VERSION in the constructor.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/marshall007/marshall_526