Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !617

fix job finished promise return value parsing when already complete

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/nkiraly/issue-614-fix-job-finished-parse-returnvalue into master Jul 12, 2017
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: nkiraly

Fixes Job.prototype.finished promise when job is already complete as determined by scripts.isFinished

returnvalue was already JSON.parse()'d during Job.prototype.fromJSON

this should address https://github.com/OptimalBits/bull/issues/614

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nkiraly/issue-614-fix-job-finished-parse-returnvalue