Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !749

Fix #739 properly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/leontastic/master into master Oct 22, 2017
  • Overview 12
  • Commits 14
  • Pipelines 0
  • Changes 3

Created by: leontastic

Failing test output:

leonli:bull (master) npm test

> bull@3.3.2 pretest /Users/leonli/Documents/Dev/packages/bull
> npm run lint


> bull@3.3.2 lint /Users/leonli/Documents/Dev/packages/bull
> eslint lib test


> bull@3.3.2 test /Users/leonli/Documents/Dev/packages/bull
> NODE_ENV=test mocha



  sandboxed process
Child process exited 36222 0 null
    1) should remove exited process


  0 passing (6s)
  1 failing

  1) sandboxed process should remove exited process:

      AssertionError: expected [ 'undefined' ] to have a length of 0 but got 1
      + expected - actual

      -1
      +0

      at test/test_sandboxed_process.js:111:65
  From previous event:
      at Queue.<anonymous> (test/test_sandboxed_process.js:110:28)
      at lib/queue.js:866:13
  From previous event:
      at handleCompleted (lib/queue.js:865:40)
  From previous event:
      at Queue.processJob (lib/queue.js:896:23)
  From previous event:
      at lib/queue.js:804:12
  From previous event:
      at lib/queue.js:802:43
      at _combinedTickCallback (internal/process/next_tick.js:131:7)
      at process._tickCallback (internal/process/next_tick.js:180:9)



npm ERR! Test failed.  See above for more details.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/leontastic/master