Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bull
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 175
    • Issues 175
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OptimalBits
  • bull
  • Merge requests
  • !908

Fix process retain when reusing a previous process

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/igncp/add-sandboxed-process-test into master Apr 05, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: igncp

I was reviewing this code and it seems that it was missing to add the child process id to the retained map. It all started while trying to add coverage for that if block.

I am not aware of many details, the previous implementation may be intended. If so, I could update this test to at least cover that condition (without the new line in lib/process/child-pool.js).

Hope it helps, cheers

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/igncp/add-sandboxed-process-test