Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PyAV
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyAV
  • PyAV
  • Merge requests
  • !1000

Use pad count in alloc_filter_pads

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/uvjustin/iterate-filter-pads-safely into main Jun 21, 2022
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: uvjustin

It doesn't seem safe to rely on the return value of lib.avfilter_pad_get_name() to iterate. The docs say that it is up to the caller to ensure the index is valid: https://ffmpeg.org/doxygen/trunk/group__lavfi.html#ga2d69631bb24a0a2b7ac0e00fe1dfab3b This seemed to be causing some spurious test errors on some platforms. Before libavfilter 8.3.100 (ffmpeg < 5.0), the function to use to get the filter count was avfilter_pad_count, but that is now deprecated. We can now use either avfilter_filter_pad_count or use the AVFilter.nb_input (output) fields directly. See https://ffmpeg.org/pipermail/ffmpeg-cvslog/2021-August/128485.html

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/uvjustin/iterate-filter-pads-safely