Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PyAV
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyAV
  • PyAV
  • Merge requests
  • !390

Defer wrapping output stream into Python object

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jeremy Lainé requested to merge github/fork/jlaine/defer-stream-wrap into develop Sep 25, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

OutputContainer.add_stream() nicely initialises some default options both for audio and video streams. Unfortunately, we wrap the low-level AVCodecContext and AVStream into Python objects before we finish initialising them.

For video streams this results in the crucial "pix_fmt" being cleared inside VideoCodecContext._init, which leads to a crash during encoding if the user does not set "pix_fmt" (again) themselves:

Assertion desc failed at libswscale/swscale_internal.h:674

With this PR we finish the CodecContext initialization before we start wrapping the stream into a Python object.

As a result of this fix, all video encoding examples can be simplified to remove this:

stream.pix_fmt = 'yuv420p'

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jlaine/defer-stream-wrap