Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PyAV
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyAV
  • PyAV
  • Merge requests
  • !528

Detect static library and pthread awareness in setup.py

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/stepheny/detect_static into develop 6 years ago
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: stepheny

It is great to stop trying to build against static ffmpeg library early. But only showing "unknown flags" -pthread is very confusing. This patch trys to check 'library_dirs' returned by parse_cflags. If system ffmpeg was used, this should be empty. If a custom built ffmpeg was used, probably in /usr/local/lib, this would be filled by pkg-config. And then check if target .so file exists there. If it does not exist, the library is probably static. In case this test could go wrong, an env var was added to bypass the test. I think this should work on linux. I've no idea how this would affect windows or macos users. I've no idea whether the env var name and error message are proper.

Loading
Loading

Activity


  • Jeremy Lainé closed 3 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
3
Breaking change (with fallback) Enhancement: CI/Test Server: PHP
3
Breaking change (with fallback) Enhancement: CI/Test Server: PHP
    Assign labels
  • Manage project labels

Milestone
3.3.0
3.3.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!898
Source branch: github/fork/stepheny/detect_static

Menu

Explore Projects Groups Snippets