Hi!
I recently found PyAv, and I am very impressed with how flexible and powerful it is compared to my old go-to-solution, which was calling ffmpeg with a subprocess call! :)
I realized that the color_range option was not implemented so I gave it a shot. Specifically, this can be needed when the default color range for YUV (0-255 or 16-235) needs to be overridden for a codec.
Since I am not deeply familiar with PyAV or the FFmpeg source code, my approach might not be the way to go, and if so I'm happy to update it based on your suggestions. In particular, the change in reformatter.pyx doesn't seem like the right solution to me. As far as I can tell it works as intended, but it definitely has a smell to it...
Also, some tests should probably also be added for this. I don't know if it's enough to test that the color_range property is set as expected when provided as an option, or if some decoding with different color_ranges are preferable?
Change-Id: I42451b3b84ea7ca4ae645566d1ef4709e0326f92
Activity
- Last updated by Johan Jeppsson
9 9 10 10 cdef _reformat(self, VideoFrame frame, int width, int height, Is it possible to enforce keywords-only arguments in Cython? With the ever-increasing number of options I'm afraid this is going to turn into a footgun. Thoughts @mikeboers ?
mentioned in issue #257 (closed)
added changes requested label
