Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PyAV
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyAV
  • PyAV
  • Merge requests
  • !948

Ensure `close` is called when Container is deleted

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Breakthrough/patch-1 into develop Mar 28, 2022
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Breakthrough

Currently, close() is only called when using a context manager. This can demonstrably lead to hangs when using AUTO threading mode as shown in the cookbook example.

As @jlaine discovered in #909 (closed), calling close() on the Container seems to resolve the issue, likely by making sure the threads have been joined by the time dealloc runs.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Breakthrough/patch-1