Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !1014

Fix #966: Adjust styles of hero and header components for short viewports

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jendowns/966_hero-height into main Jul 22, 2020
  • Overview 17
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: jendowns

Resolves #966 (closed)

As @aardrian pointed out in #966 (closed), the height: 75vh rule on the header is causing header content to cover the page navigation when the viewport height is shortened. As the viewport height is reduced, there is less space for the header's content.

I believe there are also a couple other styles contributing to this effect, and I've tried to edit only what's required to prevent the navigation from being covered up & also mimic the the layout of the current deployment. In addition, there a secondary side-effect where the CTA was covering up the numeronym definition, which meant making a couple grid edits.

Please take a look and let me know what you think! I had some issues with cached styles while looking into this, so please run these updates locally & let me know if there is something amiss.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jendowns/966_hero-height