Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !1239

Fix featured post and resource focus styling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Byte Blaze requested to merge update-featured-post-and-resource into main Apr 07, 2021
  • Overview 8
  • Commits 16
  • Pipelines 0
  • Changes 17

This PR addresses https://github.com/a11yproject/a11yproject.com/issues/1220. It refactors the featured post and resource components by splitting the concerns up into 3 distinct pieces:

  • A featured post partial
  • A featured resource partial
  • A card partial

While there is a little DRY code between the featured post and resource partials, I think it will be easier to maintain. The previous partial tried to do too much and be too clever about it, which led to causing issues with the first attempt at a fix.

These videos demonstrate the updated fixes:

https://user-images.githubusercontent.com/634191/113942628-1e75e780-97cf-11eb-8a33-04d603f264c9.mov

https://user-images.githubusercontent.com/634191/113942670-2e8dc700-97cf-11eb-9496-afacf5f58a8a.mov

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: update-featured-post-and-resource