Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !1390

Upgrade `sass` to `1.45.0`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged EJ Mason requested to merge feature/upgrade-sass into main Dec 13, 2021
  • Overview 2
  • Commits 4
  • Pipelines 0
  • Changes 14

Summary

This upgrades our version of dart-sass to 1.45.0 and includes cleanup necessary to prevent stylelint from crashing during build.

This PR completes 2 of 3 tasks in #1380 (closed). We don't need to fully migrate in order to upgrade dart-sass (yet).

Important changes

  • mappy-breakpoints is now a local dependency in css/imports. It's functionally identical to its NPM counterpart, but it makes use of new SASS syntax is so that the project can build. If the published NPM package receives appropriate updates, we can go back to using it, but I don't expect that to happen soon.
  • many of our other .scss files have been passed through sass-migrator so that they utilize new SASS syntax as well.

⚠️ Please verify that nothing important has broken in our design! I don't expect any changes, but still.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/upgrade-sass