Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !408

added blue glowing focus to linked images and btns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jeryj/gh-pages into gh-pages Mar 19, 2016
  • Overview 10
  • Commits 8
  • Pipelines 0
  • Changes 8

Created by: jeryj

I added a .btn class for reuse (surprised I didn't do that originally...) and added a blue glowing outline that mimics chrome's focus state (the blue glow). This same blue glow is used for images that are children of links.

Two thoughts:

  1. Should the added focus be a blue glow? Is there a better default?
  2. Is the blue glow enough of a contrast against our btn color? It's noticeable when the change happens when tabbing through, but not super visible. I'm concerned it'll be easy to lose track of where you are. Should the focus color be different? Other ideas on how to indicate focus in some kind of standardized way?
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jeryj/gh-pages