Skip to content
GitLab

Improve support for visually-hidden but focusable content

Merged Administrator requested to merge github/fork/mfairchild365/patch-1 into gh-pages

Created by: mfairchild365

Fixes https://github.com/a11yproject/a11yproject.com/issues/499

Some other notes/questions about this article and PR:

  • It might be good to reference a newer article than the deleted yahoo article for the .visually-hidden class.
  • I don't think we have to worry about display:none not working for screen readers anymore. The post that was referencing that as an issue is 10 years old and I don't think it is an issue anymore. In my experience, this is no longer an problem, and I haven't been able to find any more recent articles indicating that it is still a problem.
  • Adding aria-hidden in addition to display:none is over doing it in my opinion, and can lead mistakes in the future (update css to remove display:none but forget to remove the aria-hidden). I recommend removing this part, and perhaps referencing the hidden HTML attribute as another way of hiding content.

Should I make all, some, or none of these additional changes to this PR?