Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !604

Updated social share code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Byte Blaze requested to merge social-share into gh-pages Jun 13, 2018
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 4

This PR:

  • Updates the ordering of embed codes to be as robust as possible.
  • Updates the social media embed meta attributes to reflect some changes in Open Graph and Twitter embed rules.
  • Adds a generic fallback for schema.org, which should also work with Google+.
  • Adds an icon treatment specifically for social sharing.
  • Updates the favicon to not use dark blue, as that's no longer part of the site palette.

The current avatar image we use is rendered a little weird in certain contexts:

Twitter

Simulated Twitter embed. The logo is clipped on the left and right, as it does not fit the preview's aspect ratio.

Slack

Simulated Slack embed. The logo is squashed, as it does not fit the preview's aspect ratio.

So hopefully the new square treatment will get us looking our best!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: social-share