Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A a11yproject.com
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The A11Y Project
  • a11yproject.com
  • Merge requests
  • !687

Adding no width space before li elements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/petetalksweb/list-style-type-none into gh-pages Nov 25, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: petetalksweb

Addresses Issue #685 (closed)

I found a placeholder selector: %no-list-style, that seems to be used in a number of places. I thought, that I could just add the proposed CSS from the blog post linked in the issue, to %no-list-style, and be done.

Unfortunately, the table of contents applies list-style: none via a media query, and SASS does not let you extend a placeholder selector inside of a media query, so I went with the solution suggested here, and:

  • Made a mixin:no-list-style-mixin with all of the properties of the no-list-style placeholder selector
  • Added the proposed CSS solution to the no-list-style-mixin
  • Replaced the content of the no-list-style placeholder selector with no-list-style-mixin, so that the mixin is used wherever the placeholder selector is currently used
  • Added the no-list-style-mixin to the .toc class to apply to the table of contents, since you can use mixins inside of media queries
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/petetalksweb/list-style-type-none