Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A angular-storage
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Auth0
  • angular-storage
  • Merge requests
  • !18

Add tests (and fix) cookie fallback mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/kildareflare/fixCookies into master Feb 07, 2015
  • Overview 16
  • Commits 4
  • Pipelines 0
  • Changes 3

Created by: kildareflare

Hi, I was in the process of adding a reset method to this library (clear all local storage / cookies) and noticed that there were no tests for cookie fallback mode.

I also noticed that the ngCookie dependency was not declared; I may be missing something, but I don't think the cookie fallback mode will work without it.

I've added the missing dependency and written tests for the cookie fallback mode - all tests pass.

The changes for the reset method are ready to be committed, pending the merge of these changes.

This is my first pull request, so please let me know if I have missed something.

Cheers

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kildareflare/fixCookies