Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A ArduinoJson
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Benoît Blanchon
  • ArduinoJson
  • Issues
  • #1715
Closed
Open
Issue created Feb 25, 2022 by Administrator@rootContributor

Enable and fix sign-conversion warnings

Created by: armandas

We're using -Wsign-conversion GCC option and we're getting errors from ArduinoJson. The errors are caused by the following template code in RamString.hpp:

template <int N>
struct IsString<char[N]> : true_type {};

template <int N>
struct IsString<const char[N]> : true_type {};

template <int N>
inline SizedRamString adaptString(char s[N]) {
  return SizedRamString(s, strlen(s));
}

All other places use template <size_t N>.

Would it be possible to add -Wsign-conversion to the compiler options and fix the reported issues? I could create a PR.

Assignee
Assign to
Time tracking