Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A ArduinoJson
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Benoît Blanchon
  • ArduinoJson
  • Merge requests
  • !1341

Disable String reader when Stream is enabled and String derives from Stream

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/d-a-v/streamTo6 into 6.x Aug 09, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: d-a-v

This is related to PR https://github.com/esp8266/Arduino/pull/6979 (specifically this). It is opened for discussion.

This would solve this error:

sketch/StringExample.ino.cpp:
In file included from ArduinoJson/src/ArduinoJson/Json/JsonDeserializer.hpp:7,
                 from ArduinoJson/src/ArduinoJson.hpp:34,
                 from ArduinoJson/src/ArduinoJson.h:9,
                 from ArduinoJson/examples/StringExample/StringExample.ino:13:
ArduinoJson/src/ArduinoJson/Deserialization/deserialize.hpp: In instantiation of 'ArduinoJson6161_11::DeserializationError ArduinoJson6161_11::deserialize(ArduinoJson6161_11::JsonDocument&, TStream&, ArduinoJson6161_11::NestingLimit, TFilter) [with TDeserializer = ArduinoJson6161_11::JsonDeserializer; TStream = String; TFilter = ArduinoJson6161_11::AllowAllFilter]':
ArduinoJson/src/ArduinoJson/Json/JsonDeserializer.hpp:676:39:   required from 'ArduinoJson6161_11::DeserializationError ArduinoJson6161_11::deserializeJson(ArduinoJson6161_11::JsonDocument&, TInput&, ArduinoJson6161_11::NestingLimit) [with TInput = String]'
ArduinoJson/examples/StringExample/StringExample.ino:22:29:   required from here
ArduinoJson/src/ArduinoJson/Deserialization/deserialize.hpp:61:19: error: ambiguous template instantiation for 'struct ArduinoJson6161_11::Reader<String, void>'
   61 |   Reader<TStream> reader(input);
      |                   ^~~~~~
In file included from ArduinoJson/src/ArduinoJson/Deserialization/Reader.hpp:43,
                 from ArduinoJson/src/ArduinoJson/Deserialization/deserialize.hpp:10,
                 from ArduinoJson/src/ArduinoJson/Json/JsonDeserializer.hpp:7,
                 from ArduinoJson/src/ArduinoJson.hpp:34,
                 from ArduinoJson/src/ArduinoJson.h:9,
                 from ArduinoJson/examples/StringExample/StringExample.ino:13:
ArduinoJson/src/ArduinoJson/Deserialization/Readers/ArduinoStreamReader.hpp:12:8: note: candidates are: 'template<class TSource> struct ArduinoJson6161_11::Reader<TSource, typename ArduinoJson6161_11::enable_if<ArduinoJson6161_11::is_base_of<Stream, TSource>::value>::type> [with TSource = String]'
   12 | struct Reader<TSource,
      |        ^~~~~~~~~~~~~~~
   13 |               typename enable_if<is_base_of<Stream, TSource>::value>::type> {
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ArduinoJson/src/ArduinoJson/Deserialization/Reader.hpp:47,
                 from ArduinoJson/src/ArduinoJson/Deserialization/deserialize.hpp:10,
                 from ArduinoJson/src/ArduinoJson/Json/JsonDeserializer.hpp:7,
                 from ArduinoJson/src/ArduinoJson.hpp:34,
                 from ArduinoJson/src/ArduinoJson.h:9,
                 from ArduinoJson/examples/StringExample/StringExample.ino:13:
ArduinoJson/src/ArduinoJson/Deserialization/Readers/ArduinoStringReader.hpp:10:8: note:                 'template<class TSource> struct ArduinoJson6161_11::Reader<TSource, typename ArduinoJson6161_11::enable_if<ArduinoJson6161_11::is_base_of<String, TSource>::value>::type> [with TSource = String]'
   10 | struct Reader<TSource,
      |        ^~~~~~~~~~~~~~~
   11 |               typename enable_if<is_base_of< ::String, TSource>::value>::type>
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ArduinoJson/src/ArduinoJson/Json/JsonDeserializer.hpp:7,
                 from ArduinoJson/src/ArduinoJson.hpp:34,
                 from ArduinoJson/src/ArduinoJson.h:9,
                 from ArduinoJson/examples/StringExample/StringExample.ino:13:
ArduinoJson/src/ArduinoJson/Deserialization/deserialize.hpp:61:19: error: 'ArduinoJson6161_11::Reader<String, void> reader' has incomplete type
   61 |   Reader<TStream> reader(input);
      |                   ^~~~~~
Using library ArduinoJson at version 6.16.1 in folder: ArduinoJson 
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/d-a-v/streamTo6