Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A ArduinoJson
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Benoît Blanchon
  • ArduinoJson
  • Merge requests
  • !1490

Advertise ESP-IDF compatibility in library.json

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/maxgerhardt/patch-1 into 6.x Feb 02, 2021
  • Overview 8
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: maxgerhardt

Per PlatformIO forum thread this library can also be used with ESP-IDF. It's just that PlatformIO refuses by default to use this library in a project that has framework = espidf and not arduino because the library.json only advertises arduino compatibility and a user needs to do lib_compat_mode = off to bypass the compatibility check.

Per docs I've expanded the library.json.

You might also want to expand the detection code for

https://github.com/bblanchon/ArduinoJson/blob/322d13de0d9e42862321af458a7438c0e7aa15a2/src/ArduinoJson/Configuration.hpp#L23-L34

So that the macro ends up having the value 1, the same as in Arduino. The check #if defined(IDF_VER) might e.g. be used for that (defined during build process -DIDF_VER=\"3.40200.210118\"), or check on __xtensa__ (compiler does #define __xtensa__ 1). I left that out in this PR because I'm not 100% sure on what you want this macro value to be in an ESP-IDF environment.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/maxgerhardt/patch-1