Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M millennials-to-snake-people
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Byte Blaze
  • millennials-to-snake-people
  • Merge requests
  • !24

Add checks to avoid replacing user-editable content. Fixes #21, #13

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/SnoopJ/editable-bugfix into master May 03, 2017
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: SnoopJ

This checks if the mutated node (or its parent) has the contenteditable attribute (fixes cursor issues with DraftJS/Gmail a la #21 (closed)), or is a textarea or input field (following #22 in an extensible way, and should address some of #13 (closed))

This seems to fix all issues with Facebook/DraftJS, but doesn't catch every corner for Gmail. In particular, typing "millenial" in the To field will still trigger a replacement (I'm not clear if this actually affects the recipient or is strictly cosmetic). However, the body of the message and the subject should be unaffected by the extension.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/SnoopJ/editable-bugfix