Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Issues
  • #162
Closed
Open
Issue created Mar 26, 2020 by Administrator@rootContributor

Need for static code analysis setup

Created by: vinay-thallam

It is observed that, though eslint config is present in the repo, source code has many lint rule violations. Eg: assignments to variables that are never used, Usage of == instead of === in few places, missing trailing commas, indentation and space issues.

Not having having proper check on these may result in potential bugs.

This can be solved by adding few things listed below,

  • prettier setup for code formatting.
  • VS Code recommended extensions file and settings to do format on file save.
  • Pre-commit hook to do lint fix and format fix ( takes care if developers not using VS code as their IDE )
  • Lint and prettier Validate npm scripts in package.json ( can be invoked manually OR in CI if required)
Assignee
Assign to
Time tracking