Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !1184

fixed scrolling of pages when navbar is open and close navbar from outside in desktop

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Binu42/navbar into master Apr 16, 2020
  • Overview 10
  • Commits 25
  • Pipelines 0
  • Changes 2

Created by: Binu42

Description of PR

  • fixed scrolling of pages when navbar is opened.
  • close navbar from outside click of expand in desktop.
  • close navbar on click of covid19India in navbar otherwise it going to homepage and still navbar is open.
  • show active page in navbar.

Type of PR

  • Bugfix

Relevant Issues
Fixes #1190 (closed), Fixes #1311 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Demo

Before Fix (Desktop)

desktop demo before

After Fix (Desktop)

desktop demo after

Before Fix (Mobile)

mobile demo before

After Fix (Mobile)

mobile demo after

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Binu42/navbar