Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !1366

Fix: Resolve bloodhound search on initial load or first remote query.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/abdulghanitech/master into master Apr 21, 2020
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: abdulghanitech

Description of PR The search bar on the homepage for searching cities, essentials, wasn't working fine on selecting something from predefined essentials from the given list.

Even after selecting an essential thing, the search didn’t happen, I've tried the enter key from keyboard or clicking the search icon nothing worked.

So, in order to fix this bug, I went through the typeahead library which we're using in this project and got to know about the problem. And the problem was the remote data fetching is an asynchronous task and we were trying to handle it with a normal synchronous function. I just fixed it.

Type of PR

  • Bugfix
  • New feature

Relevant Issues
Fixes #...

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots ezgif com-optimize (1)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/abdulghanitech/master