Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !1932

Bug fix for issue #1924: Counter overlapping issue for smaller screens

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/gurudeb/bug-fix/1924 into master May 19, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: gurudeb

Description of PR

For smaller screen resolutions the counter values were overlapping producing a bad UX. This PR fixes that issue by reducing the font sizes of counters for smaller screen resolutions. There are 2 additional media queries present which reduces the font size in steps i.e. for width 480px and below the counter font size has been reduced from 24px to 21px and for width below 380px the font size has been reduced further to 18px. This fixes the counter overlapping issue. Future scope has also been considered such as when counter value changes to larger digits e.g. active cases reach a 6 digit count (currently active cases are in 5 digit count). There also this fix will work. All regression scenarios has been considered and tested to be working properly.

Relevant Issues
Fixes #1924 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots Issue screenshot: image

After fix screenshot: image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gurudeb/bug-fix/1924