Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !212

static analysis testing (lint and format) setup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/vinay-thallam/master into master Mar 27, 2020
  • Overview 6
  • Commits 14
  • Pipelines 0
  • Changes 25+

Created by: vinay-thallam

fixes #162 (closed)

Below items are taken care in this PR.

  • Using prettier to take care of code formatting rules and continued to take code quality rules from google's style guideline
  • Fixed the existing eslint violations in code
  • Added "dbaeumer.vscode-eslint" and "esbenp.prettier-vscode" extensions in vs code recommendations
  • Added setting to do format on save of JS and JSON files using prettier
  • Added pre-commit hook to do lint fix and format fix. This prevents commit if there exists lint errors in code unless you use --no-verification flag with git commit

Note : Added "validate" script in package.json which can be included in CI pipeline. I have not added it in github workflow file, since I am not sure when to trigger it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/vinay-thallam/master