Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !2211

FIX:: Bugfix for Tooltip overflow

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/sirdarthvader/fix/2076-Tooltip-Overflow into master Jul 05, 2020
  • Overview 7
  • Commits 4
  • Pipelines 0
  • Changes 4

Created by: sirdarthvader

Description of PR

This PR is against the issue number #2076 (closed)

The issue was with the default position of the tooltip, while it was not an issue on desktop, for mobile devices, tooltip created this extra space in the body of the page.

So I have added a conditional style object for tooltip element basis the viewport size of the device. If it's a mobile device tooltip element would have added top and right CSS attributes keeping it overflowing from viewport.

Introduced a new custom hook function called located in useViewPort.js under the hooks folder.

All the proposed changes will have an effect only on devices smaller or equal to 480px in width.

Relevant Issues
Fixes #2076 (closed)

Checklist

  • Compiles and passes lint tests

  • Properly formatted

  • Tested on desktop

  • Tested on phone

Screenshots

Add relevant screenshots here As seen on production

Screenshot 2020-07-05 at 2 37 39 PM

Changes from this PR

Screenshot 2020-07-05 at 2 38 16 PM
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sirdarthvader/fix/2076-Tooltip-Overflow