Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !2233

Style: Fixed incorrect timeline position when language selector is open

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tanmaybhatt/master into master Jul 10, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: tanmaybhatt

Description of PR Dates Timeline used to overlap with the language selector. Fixed it by adding a parent div so that absolute positioning of the timeline corresponds to the position of this parent. Secondly, timeline was not in the center on the phone, fixed that as well. Though still the initial position of the timeline on the phone is little off. But I think that is intended since there are only two dates to be shown initially.

Relevant Issues
Fixes #2225 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots screenshot-localhost_3000-2020 07 10-21_29_12 screenshot-localhost_3000-2020 07 10-21_30_48

Centered Timeline on phone screenshot-localhost_3000-2020 07 10-21_32_44

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tanmaybhatt/master