Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !2508

Fixes the weird placeholder strings appearing when language was changed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/sbhrwlr/langissue into master Jun 30, 2021
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: sbhrwlr

Fixes #2507 (closed)

A brief description of what changes your PR introduces. The better this description, the quicker we can review, exchange feedback, and merge! After changing language the placeholder was displaying weird strings and not the cities suggestion you added it was happening because of useCallback function that starts running and do not terminate the priveous instance of useCallback I added language dependency to useCallback and function will terminate whenever the language state changes.

Fixes #2507 (closed)

✔️ Compiles and passes lint tests ✔️ Properly formatted ✔️ Tested on desktop ✔️ Tested on phone

Before Fixing Screenshot :

initially Initially wrong strings

After Fixing Screenshots

now

nowtwo :

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sbhrwlr/langissue