Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !400

Fixed react-hooks dependency lists errors and warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jeremy requested to merge pr/328 into master Mar 30, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 11
  • Thanks to @ssonal!

Also there seemed to be a problem with the minigraphs rendering. Having timeseries, Graphdata, and time series.length in the dependency list redrew the d3 graphs multiple times. I've disabled that for now so if you can come up with a fix for it next, we can start enforcing the react-hooks rules in the eslint.js files :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pr/328