Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !776

Further modifications to trend charts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/shuklaayush/feature/responsive-charts-rb into master Apr 07, 2020
  • Overview 3
  • Commits 12
  • Pipelines 0
  • Changes 4

Created by: shuklaayush

Description of PR

  • Make the trend charts' SVG fully responsive by adding a custom resizeObserver hook. Fixes scaling issues in landscape orientation on mobile/tablets.
  • Remove extra divs and SVG elements; draw total and daily charts on same elements
  • Add a transition animation between total and daily charts

Type of PR

  • Bugfix
  • New feature

Relevant Issues Fixes #792 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots Peek 2020-04-07 22-35

Peek 2020-04-07 22-33

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shuklaayush/feature/responsive-charts-rb