Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !831

Add loading spinner on demographic page + use suspense for data fetching

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/punitcodes/master into master Apr 09, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: punitcodes

Description of PR

This PR adds a spinner on Demographics Page while the data is being fetched. Uses the recently introduced Suspense feature of React.

In near future, we can use this data fetching technique on all pages and also add Error Boundaries to show error.

Type of PR

  • Bugfix
  • New feature

Relevant Issues Fixes #826 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshot

screenshot-covid19india-react-git-fork-punit2502-master covid19india now sh-2020 04 09-14_39_23

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/punitcodes/master