Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C covid19india-react
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • covid19india
  • covid19india-react
  • Merge requests
  • !865

Make maps more responsive

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shuklaayush/feature/map-transitions into master Apr 09, 2020
  • Overview 5
  • Commits 15
  • Pipelines 0
  • Changes 4

Created by: shuklaayush

Description of PR This PR will

  • Increase map sizes by making them span entire width of the section
  • Cache maps which have previously been loaded. Toggle the display style of extra maps to 'none' when they're out of view, instead of removing them from SVG
  • Add zoom animation to transitions between country and state maps
  • Move legend below map. Use d3-scale instead of manual interpolation
  • Move the district information text above the map
  • Sneak in uniform scaling disabled by default

PS : I'm aware that animations stutter on Chromium-based browsers on Android. This seems to me like a bug in how SVGs are rendered in Chromium. The behaviour's better in Chrome Canary. Since I don't have the slightest idea as to how debugging is done in Chrome/Android, any help is much appreciated.

Type of PR

  • Bugfix
  • New feature

Relevant Issues
Fixes #57 (closed) (finally) , fixes #504 (closed), fixes #785 (closed) (somewhat), fixes #1045 (closed)

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots Peek 2020-04-10 13-13

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shuklaayush/feature/map-transitions