Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D diffux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Diffux
  • diffux
  • Merge requests
  • !84

Add animation to sweep progress bars with bootstrap class. Resolves #77.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Flarnie Marchan requested to merge github/fork/flarnie/master into master 11 years ago
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 3

Summary of changes:

  • Changes #sweep_progress_bar view helper by adding different classes to element depending on the number of pending sweeps. If pending sweeps are 0, (and the sweep is completed), then the class doesn't have animated stripes.
  • Adds 2 new specs to check that class is being appropriately applied depending on the number of pending sweeps.
  • All specs passing.
Approval is optional

Merged by (Jul 24, 2025 12:21am UTC)

Loading

Activity


  • Administrator
    Administrator @root · 11 years ago
    Contributor

    Created by: lencioni

    Thanks for the pull request @paradasia! Overall the code looks pretty good and I'm glad that you included specs. I left some comments inline for your consideration. If you don't have the time or desire to polish things up, just let me know and I'll be happy to take over.

    One general comment is that it would be really great to have a better commit message. In fact, some of the details you included in your pull request could be added to the commit message. In my mind, a great commit message explains why the change is being made. Thoughts, motivations, attempts, drawbacks, edge cases, and other things like that are also good to include if you have any.

    Thanks for contributing! @trotzig and I are delighted.

  • Flarnie Marchan
    Flarnie Marchan @flarnie · 11 years ago
    Author Contributor

    Thanks for reviewing the code and for your comments - I just didn't notice your inline comments, and am happy to make the changes you mentioned to the specs. I'm always happy to contribute and to improve my code.

  • Administrator
    Administrator @root · 11 years ago
    Contributor

    Merged by: lencioni at 2014-03-30 16:28:45 UTC

  • Henric Trotzig
    Henric Trotzig @trotzig · 11 years ago
    Contributor

    Thanks @paradasia, and welcome to the team of contributors!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
3
3 participants
Administrator
Henric Trotzig
Flarnie Marchan
Reference: diffux/diffux!84
Source branch: github/fork/flarnie/master

Menu

Explore Projects Groups Snippets