From 9ed18114fa28cc3c023e8af6ccaaa8a02126b35f Mon Sep 17 00:00:00 2001
From: cclauss <cclauss@bluewin.ch>
Date: Sat, 10 Mar 2018 03:36:57 +0100
Subject: [PATCH 1/2] =?UTF-8?q?LARGE=20=E2=80=94>=20VehicleSize.LARGE?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The class name is required in this context.
---
solutions/object_oriented_design/parking_lot/parking_lot.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/solutions/object_oriented_design/parking_lot/parking_lot.py b/solutions/object_oriented_design/parking_lot/parking_lot.py
index 9167d9f..2e113cb 100644
--- a/solutions/object_oriented_design/parking_lot/parking_lot.py
+++ b/solutions/object_oriented_design/parking_lot/parking_lot.py
@@ -45,7 +45,7 @@ class Car(Vehicle):
super(Car, self).__init__(VehicleSize.COMPACT, license_plate, spot_size=1)
def can_fit_in_spot(self, spot):
- return True if (spot.size == LARGE or spot.size == COMPACT) else False
+ return bool(spot.size in (VehicleSize.LARGE, VehicleSize.COMPACT))
class Bus(Vehicle):
@@ -54,7 +54,7 @@ class Bus(Vehicle):
super(Bus, self).__init__(VehicleSize.LARGE, license_plate, spot_size=5)
def can_fit_in_spot(self, spot):
- return True if spot.size == LARGE else False
+ return bool(spot.size == VehicleSize.LARGE)
class ParkingLot(object):
--
GitLab
From 890a2673f47ae955c48bb75201ab5c616e16cd37 Mon Sep 17 00:00:00 2001
From: cclauss <cclauss@bluewin.ch>
Date: Mon, 26 Mar 2018 04:55:11 +0200
Subject: [PATCH 2/2] Remove bool() * 2
---
solutions/object_oriented_design/parking_lot/parking_lot.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/solutions/object_oriented_design/parking_lot/parking_lot.py b/solutions/object_oriented_design/parking_lot/parking_lot.py
index 2e113cb..12fcd24 100644
--- a/solutions/object_oriented_design/parking_lot/parking_lot.py
+++ b/solutions/object_oriented_design/parking_lot/parking_lot.py
@@ -45,7 +45,7 @@ class Car(Vehicle):
super(Car, self).__init__(VehicleSize.COMPACT, license_plate, spot_size=1)
def can_fit_in_spot(self, spot):
- return bool(spot.size in (VehicleSize.LARGE, VehicleSize.COMPACT))
+ return spot.size in (VehicleSize.LARGE, VehicleSize.COMPACT)
class Bus(Vehicle):
@@ -54,7 +54,7 @@ class Bus(Vehicle):
super(Bus, self).__init__(VehicleSize.LARGE, license_plate, spot_size=5)
def can_fit_in_spot(self, spot):
- return bool(spot.size == VehicleSize.LARGE)
+ return spot.size == VehicleSize.LARGE
class ParkingLot(object):
--
GitLab