Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S system-design-primer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 173
    • Issues 173
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 190
    • Merge requests 190
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Donne Martin
  • system-design-primer
  • Merge requests
  • !714

en: Refactored duplicate code in online_chat

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Parvez M Robin requested to merge github/fork/parvezmrobin/master into master Oct 28, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

The changes made and their justifications are as follows

Change Justification
meesage → message Typo
# ... → pass Synchronizing .ipynb and .py
def receive_friend_request(self, friend_id): → def check_pending_friend_requests(self): In real-world scenario, we do not immediately react to a friend request. Rather, when we have time we check the list of pending friend requests and accept or reject them.
Moving add_user and remove_user functionality to Chat Both PrivateChat and GroupChat share these functionality. Thus, it is only convenient to move them to the parent class.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/parvezmrobin/master