Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PyTorch-GAN
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 102
    • Issues 102
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Erik Linder-Norén
  • PyTorch-GAN
  • Issues
  • #92
Closed
Open
Issue created Feb 04, 2020 by Lukas Blecher@lukas-blecher

ESRGAN: incomplete loss_GAN

Hi, I think the loss_GAN in esrgan.py is missing a term. In the ESRGAN paper the adversarial loss is like the discriminator loss a sum of two terms. formula However as far as I understand the code, only the second part is implemented in esrgan.py#L135. The following line would do the trick in my opinion.

loss_GAN = (criterion_GAN(pred_fake - pred_real.mean(0, keepdim=True), valid) + 

            criterion_GAN(pred_real - pred_fake.mean(0, keepdim=True), fake))/2
Assignee
Assign to
Time tracking