Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1201

Close test result output file properly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/kageiit/close_stream into master Feb 22, 2017
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: kageiit

Currently, the BaseRunner does not correctly close the underlying FileOutputStream when writing test results out. This is because the current close() call is only performed on BufferedOutputStream which simply class flush() on the underlying stream but never closes it. This leads to too many files open exception and the test run exiting prematurely when there are several test rules running on a machine at the same time. This change fixes that problem

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kageiit/close_stream