Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1248

Fix broken showcase page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/sdwilsh/fix-showcase into master Mar 15, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: sdwilsh

https://github.com/facebook/buck/pull/1239 was a little broken:

  1. Image links weren't right, so they didn't render on the page
  2. The code used the old moreInfo instead of links in the map, causing the links to not render

This change fixes that. It also removes "Word Search Star" because there is no HTTPS image available from the iTunes store, and it is not published in the Play store.

Test Plan: .\docs\soyweb-local.ps1 and then loaded http://localhost:9811/about/showcase.html

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sdwilsh/fix-showcase