Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1296

entitlements file uses info_plist_substitutions for variable substitution

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ProfessaA/master into master Apr 19, 2017
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 13

Created by: ProfessaA

background

Currently, apple_bundles can take info_plist_substitutions that are used to replace variables in the specified info_plist. However, variable substitution does not occur for the entitlements file. This makes it tricky to share things like GROUP_ID or AppIdentifierPrefix that need to match across the plist and entitlements files. It also diverges from xcode's behavior where variables set in build settings can be accessed in both the info plist and entitlements files.

change

This PR makes it so that info_plist_substitutions are also applied to the entitlements file specified via CODE_SIGN_ENTITLEMENTS.

verification

  • add AppleBundleIntegrationTest.infoPlistSubstitutionsAreAppliedToEntitlements
  • verify that app with entitlements variables can be correctly code signed and launched on device
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ProfessaA/master