Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1315

Xcode project generator expands location macros in linker flags

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ProfessaA/project_generator_expands_location_macros into master May 01, 2017
  • Overview 25
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: ProfessaA

background

Previously, ProjectGenerator did not expand location macros used in linker flags. As a result, buck builds for targets with linker flags using location macros would succeed but building a project generated from the same target would fail.

change

ProjectGenerator now expands location macros to their absolute path and adds the macro's build target to the ProjectGenerator's list of required targets.

verification

  • add ProjectGeneratorTest.testAppleLibraryLinkerFlagsWithLocationMacrosAreExpanded
  • buck test test/com/facebook/buck/apple/project_generator:project_generator
  • verify that buck project generates a project with linker flag location macros correctly expanded, and that the targets of those macros were built as part of project generation
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ProfessaA/project_generator_expands_location_macros