Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1317

actool uses correct value for '--minimum-deployment-target' flag

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ProfessaA/actool_uses_correct_min_deployment_target into master May 03, 2017
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: ProfessaA

background

Previously, the actool command to compile asset catalogs passed a hard-coded 7.0 to the --minimum-deployment-target flag.

change

Now the correct value, taken from AppleCxxPlatform#getMinVersion, is passed to the --minimum-deployment-target flag.

verification

  • AppleBundleIntegrationTest#appleAssetCatalogsAreIncludedInBundle passes
  • buck build project with deployment target of 9.0 and verify that the Assets.car file is correct
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ProfessaA/actool_uses_correct_min_deployment_target