Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1345

Add apple test's host app as a target dependency in generated xcode project

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ProfessaA/project_generator_adds_test_host_app_as_target_dependency into master May 13, 2017
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 6

Created by: ProfessaA

background

Previously, the generated xcode project for apple_tests that specified a host app, did not add the app under the test's "Target Dependencies" build phase. As a result, these tests failed to build if the host app hadn't already been built.

change

Adds the host app under the test target's "Target Dependencies" build phase.

verification

  • verify that the host app is a target dependency for unit tests with a specified host app
  • verify that the host app is a target dependency for UI tests
  • verify that logic tests without host apps continue to be generated correctly
  • verify that tests with host apps in a different project don't add the app as a target dependency
  • update ProjectGeneratorTest
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ProfessaA/project_generator_adds_test_host_app_as_target_dependency