Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1410

[IntelliJ] Handle resources_root in project generation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/zhan-xiong/zhan.xiong/project_generation_resource_folders into master Jul 03, 2017
  • Overview 55
  • Commits 37
  • Pipelines 0
  • Changes 37

Created by: zhan-xiong

IntelliJ project generation right now doesn't generate resource folders for Java code, instead relying directly on the generation of source folders. This results in resources being put in the wrong places if resources_root is different from the Java src_roots option. This change introduces a new type of IjFolder (JavaResourceFolder) which tracks resources_root if it is set and sets the relativeOutputPath of the IntelliJ folders to try and handle this correctly.

Note that it probably can't be fully handled correctly if there are source files and resource files mixed in the same directories, because IntelliJ's granularity only goes to the directory level, while buck can set them at the file level.

I'm not entirely sure if this is the best approach to handling this, would appreciate any suggestions

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/zhan-xiong/zhan.xiong/project_generation_resource_folders