Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1414

Fix split_zip step exception

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/kageiit/fix_dups_proguard into master Jul 11, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: kageiit

I am trying out release builds with buck and am seeing a weird issue during proguard. Without obfuscation, everything works fine and dandy. With obfuscation, I see stuff like

classpath android/support/v7/widget/ListPopupWindow$1 is contained in multiple dex stores:

It is usually some layout's anonymous inner classes.

Upon debugging further it seems like there are duplicate entries in the list of dex stores that cause the exception to be thrown unnecessarily.

screen shot 2017-07-10 at 10 55 48 pm

This change removes the source of the duplication without affecting the check. Verified that the split_zip step works correctly after this change when proguard obfuscation is enabled for a test build

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kageiit/fix_dups_proguard