Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B buck
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 201
    • Issues 201
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • buck
  • Merge requests
  • !1552

Xcode modular static lib for apple_library

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/robbertvanginkel/rename_fwlib into master Sep 29, 2017
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: robbertvanginkel

There's a flag modular on apple_library that previously set some flags different so Xcode would correctly generate modular frameworks. In Xcode 9 there's also support for static swift libraries, which we want to support in buck. Unfortunately Xcode doesn't support modular static libraries by setting some Xcode config flags, so buck will have to generate the required modulemaps during project generation.

To support this we should make use of the modular flag. This PR changes the use of the modular flag so that it can be used for both modular frameworks as well as static libraries.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/robbertvanginkel/rename_fwlib